Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Separator #549 #1648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Additional Separator #549 #1648

wants to merge 1 commit into from
+18 −7

Conversation

SougandhS
Copy link
Contributor

This PR provides additional separation and arrangements between Enable/Disable Actions in breakpoints view. New actions can be contributed here.

Part of Enhancement #eclipse-jdt/eclipse.jdt.debug#550

@SougandhS
Copy link
Contributor Author

Hi @iloveeclipse , pls check this additional separator for eclipse-jdt/eclipse.jdt.debug#550 (comment)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Test Results

 1 668 files   -    87   1 668 suites   - 87   1h 17m 44s ⏱️ - 16m 2s
 3 573 tests  -   597   3 552 ✅  -   596   21 💤  - 1  0 ❌ ±0 
11 316 runs   - 1 791  11 157 ✅  - 1 786  159 💤  - 5  0 ❌ ±0 

Results for commit 2a6339b. ± Comparison against base commit 5d8ee71.

This pull request removes 597 tests. 
AllTests ApiDocTest ‑ testTopicsReference
AllTests LinkTest ‑ testAllLinks
AllTests TocLinkChecker ‑ testJdtIsvGenerated
AllTests TocLinkChecker ‑ testJdtIsvStatic
AllTests TocLinkChecker ‑ testJdtUser
AllTests TocLinkChecker ‑ testPdeUserGenerated
AllTests TocLinkChecker ‑ testPdeUserStatic
AllTests TocLinkChecker ‑ testPlatformIsvGenerated
AllTests TocLinkChecker ‑ testPlatformIsvStatic
AllTests TocLinkChecker ‑ testPlatformUser
…

♻️ This comment has been updated with latest results.

@SougandhS SougandhS mentioned this pull request Dec 2, 2024
Open
3 tasks
@jukzi
Copy link
Contributor

jukzi commented Dec 4, 2024

please post before/after screenshot

@SougandhS
Copy link
Contributor Author

eclipse-jdt/eclipse.jdt.debug#550 (comment)

As of now visually it doesn't make difference

before - image

after -
image

But this will help in arranging a new option in the proper position
eclipse-jdt/eclipse.jdt.debug#550 (comment)
391035940-c62fc2be-7a87-4c44-8ba8-0dfaa292b9e6

jukzi
jukzi reviewed Dec 4, 2024
View reviewed changes
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/IDebugUIConstants.java
* Identifier for breakpoint operations other than enable/disable succeeding a
* breakpoint group in a menu (value <code>"BreakpointAdditionalGroup"</code>).
*
* @since 3.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new public api

@jukzi
Copy link
Contributor

jukzi commented Dec 4, 2024

Build fails with missing version increment:

13:48:30.402 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.debug.ui: There are API errors:
13:48:30.402 [ERROR] META-INF/MANIFEST.MF:5 The minor version should be incremented in version 3.18.700, since new APIs have been added since version 3.18.600
13:48:30.402 [ERROR] -> [Help 1]

@SougandhS
Copy link
Contributor Author

Build fails with missing version increment:

13:48:30.402 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.debug.ui: There are API errors:
13:48:30.402 [ERROR] META-INF/MANIFEST.MF:5 The minor version should be incremented in version 3.18.700, since new APIs have been added since version 3.18.600
13:48:30.402 [ERROR] -> [Help 1]

will do a version bump

@SougandhS SougandhS force-pushed the MenuSeperator branch 2 times, most recently from d1502ce to 8ff4f6f Compare December 4, 2024 14:47
@SougandhS
Additional Separator eclipse-platform#549
2a6339b 
This PR provides additional separation and arrangements between
Enable/Disable Actions in breakpoints view. New actions can be
contributed here.

Part of Enhancement #eclipse-jdt/eclipse.jdt.debug#550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukzi jukzi jukzi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SougandhS @jukzi